fix "scandir should not need to sort in b.php (banner code)"
scandir by default sorts files in ascending order. this is unnecessary when you're picking a random file anyway. it's just wasting CPU cycles and increasing latency as more files are added. currently it is $files = scandir($dir); it should be $files = scandir($dir, SCANDIR_SORT_NONE);
This commit is contained in:
parent
582b123be4
commit
6e15e696ce
2
b.php
2
b.php
|
@ -1,6 +1,6 @@
|
||||||
<?php
|
<?php
|
||||||
$dir = "static/banners/";
|
$dir = "static/banners/";
|
||||||
$files = scandir($dir);
|
$files = scandir($dir, SCANDIR_SORT_NONE);
|
||||||
$images = array_diff($files, array('.', '..'));
|
$images = array_diff($files, array('.', '..'));
|
||||||
$name = $images[array_rand($images)];
|
$name = $images[array_rand($images)];
|
||||||
// open the file in a binary mode
|
// open the file in a binary mode
|
||||||
|
|
Loading…
Reference in New Issue
Block a user