leftypol
/
leftypol
4
5
Fork 2
Code Issues 51 Pull Requests 1 Projects Releases Wiki Activity
Labels Milestones

Add IPv6 support for DNSBL #48

Merged
nonmakina merged 5 commits from ipv6-dnsbl into config 3 years ago
Conversation 1 Commits 5 Files Changed 2
discomrade commented 3 years ago
Collaborator

Allows DNSBL to block IPv6 addresses. Briefly tested.

(Should have used the library but didn't want to experiement and possibly break the includes)

Allows DNSBL to block IPv6 addresses. Briefly tested. (Should have used the library but didn't want to experiement and possibly break the includes)
discomrade added 1 commit 3 years ago
44dd1ef6f6 Add IPv6 support for DNSBL
discomrade added 1 commit 3 years ago
nonmakina reviewed 3 years ago
inc/functions.php Outdated
return;
$ipaddr = ReverseIPOctets($_SERVER['REMOTE_ADDR']);
if (isIPv6()) {
nonmakina commented 3 years ago
Poster
Collaborator

re: supporting IPv6: very nice.

re: supporting IPv6: very nice.
discomrade marked this conversation as resolved
nonmakina reviewed 3 years ago
inc/functions.php Outdated
return strrev(implode(".", str_split(str_replace(':', '', inet_expand($ip)))));
}
// copypastad from lib/IP/Lifo/IP.php, TODO replace this with a proper include
nonmakina commented 3 years ago
Poster
Collaborator

why not just include the file?
a require_once should work?

why not just include the file? a require_once should work?
discomrade commented 3 years ago
Poster
Collaborator

Threw a 500 internal error when I tried. Didn't investigate as I believe this functionality is needed immediately.
Edit: there was a typo in the filepath.

Threw a 500 internal error when I tried. Didn't investigate as I believe this functionality is needed immediately. Edit: there was a typo in the filepath.
discomrade marked this conversation as resolved
discomrade added 2 commits 3 years ago
discomrade added 1 commit 3 years ago
nonmakina commented 3 years ago
Collaborator

Great job, as always!

Great job, as always!
nonmakina merged commit 0070318b0d into config 3 years ago
discomrade deleted branch ipv6-dnsbl 2 years ago
The pull request has been merged as 0070318b0d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something is not working devops
Devops related, rather than software duplicate
This issue or pull request already exists feature request
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug devops duplicate feature request help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ipv6-dnsbl'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes