leftypol
/
leftypol
4
5
Fork 2
Code Issues 57 Pull Requests 1 Projects Releases Wiki Activity
Labels Milestones
New Issue

Ban overhaul #101

Open
opened 2 months ago by Zankaria · 3 comments
Zankaria commented 2 months ago
Collaborator

A warning would be a ban that automatically expires when first viewed.

A warning would be a ban that automatically expires when first viewed.
Zankaria added the
feature request
 label 2 months ago
Zankaria commented 2 months ago
Poster
Collaborator

How do we prevent a warning from lingering in the db forever if the user never opens the page?
This would require a much longer hidden timeout, after which the warning expires silently

How do we prevent a warning from lingering in the db forever if the user never opens the page? This would require a much longer hidden timeout, after which the warning expires silently
Zankaria changed title from [Feature Request] Add warning pseudo-ban to [Feature Request] Ban overhaul 2 months ago
Zankaria commented 2 months ago
Poster
Collaborator

We have 3 cases

  • Immediate ban
  • Dereferred ban
  • Warning

An immediate ban is how things work right now.
Dereferred bans and warnings trigger only when the offending IP first interacts with the site, and start counting from that point. To prevent them from lingering in the db forever, they should have a second hidden timeout after which they get triggered anyway, regardless of the user having visualized the ban or not.

Warnings and dereferred bans are basically the same thing, but differ by how long they last.
There is the proposal to just merge them and simply change the offending user UI if the ban time was bellow a certain quota.
This could probably simplify the implementation, but it would remove the mapping from user concepts to code.

We have 3 cases - Immediate ban - Dereferred ban - Warning An immediate ban is how things work right now. Dereferred bans and warnings trigger only when the offending IP first interacts with the site, and start counting from that point. To prevent them from lingering in the db forever, they should have a second hidden timeout after which they get triggered anyway, regardless of the user having visualized the ban or not. Warnings and dereferred bans are basically the same thing, but differ by how long they last. There is the proposal to just merge them and simply change the offending user UI if the ban time was bellow a certain quota. This could probably simplify the implementation, but it would remove the mapping from user concepts to code.
Zankaria commented 3 weeks ago
Poster
Collaborator

Upstream vichan seems to a draft for the warning feature.
https://github.com/vichan-devel/vichan/pull/598
Need to look into it.

Upstream vichan seems to a draft for the warning feature. https://github.com/vichan-devel/vichan/pull/598 Need to look into it.
Zankaria added
feature proposal
 and removed
feature request
 labels 3 days ago
Zankaria changed title from [Feature Request] Ban overhaul to Ban overhaul 3 days ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
block_mass_delete_threads
config
display-appeal-src-ip
dockerize
fix-hud-dash
gitIgnore1
lazyLoading
mitigate-move-dataloss
safer-thread-move
tinyboard_noise
Labels
Apply labels
Clear labels
bug
Something is not working devops
Devops related, rather than software duplicate
This issue or pull request already exists feature proposal
A feature or change that could be implemented feature request
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug devops duplicate feature proposal feature request help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes