From a5b990846d55901e57b7da60ec513c9783f37f7a Mon Sep 17 00:00:00 2001
From: discomrade <nice@try.fbi>
Date: Thu, 10 Jun 2021 08:07:56 -0200
Subject: [PATCH] Add validation, remove redundant validation

---
 templates/themes/overboards/theme.php | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/templates/themes/overboards/theme.php b/templates/themes/overboards/theme.php
index 90f6b4e3..34b9b6b0 100644
--- a/templates/themes/overboards/theme.php
+++ b/templates/themes/overboards/theme.php
@@ -49,17 +49,20 @@
 		 */
 		private function parseSettings(&$settings) {
 			foreach ($settings as &$overboard) {
-				if (!is_numeric($overboard['thread_limit']))
+				if (!is_int($overboard['thread_limit']) || $overboard['thread_limit'] < 1)
 				{
-					error('Invalid configuration parameters.', true);
+					error('thread_limit must be an integer above 1.', true);
 				}
-
-				$overboard['thread_limit'] = intval($overboard['thread_limit']);
-
-				if ($overboard['thread_limit'] < 1)
+				if (!is_array($overboard['exclude'])) 
 				{
-					error('Invalid configuration parameters.', true);
+					error('Exclude list must be array of strings.', true);
+				}
+				foreach ($overboard['exclude'] as &$board) {
+					if (!is_string($board)){
+						error('Exclude list must be array of strings.', true);
+					}
 				}
+					
 			}
 
 			return $settings;