Rebase leftypol on upstream Vichan #4

Using Lainchan as a base proved to be an error in the long run.

Some Lainchan-specific and Leftypol-specific features will need to be rebase or ported to upstream Vichan. What are they? We need a list

Notes shamelessly stolen from Disco

No idea of what has already been upstreamed to Vichan in the meantime.

Welcome to sticky. Edit it as things change.

Current tasks:

||| Disco:

check for updates on https://github.com/vichan-devel/vichan/pull/463
verify the SQLs all match the appropriate implementation (e.g. nfp vs vichan warnings?)
||| '''Anti:'''

||| '''Misato:'''

—————————————————————–
—————————————————————–
—————————————————————–

Outstanding issues: [note: this doesn't include missing requested features in current leftypol]

Functional

CUSTOM SPAM FILTERS IGNORED UNTIL END, including the adding of fresh ones
CAPTCHA ignored until end, my lainchan changes are contradictory
see various commits, including: 7571df84c8''
https://infosec.mozilla.org/guidelines/web_security#x-xss-protection (esp mod cookies to mod.php)
captcha on post report appears to be broken [if solved, move its $config setting to CAPTCHAs]
go through the themes and either header template for mobile compatability
e.g.: 3eea75ef77
attach thread stats to Unique IPs directly, not implicitly (wontfix?)
document that captcha requires php curl , ban require php bc or math
^^^ I think ext-bcmath is a hard requirement of the lifo/ip composer package now
-test all features, esp. warning

? log.php : $config['mod']['mod_board_log'] is undefined can't reproduce?

show all announcements page (announcements.html) not loading can't reproduce
double escaping for subject line in OP page title [check meta tags too]
fix the thread auto-update and bottom menu to a bottom bar
PM inbox shows ( unread) when there are none unread
make statistics archive itself daily, as it is currently very short-term
omitted vichan's move from instance-config.php->secrets.php, seems incomplete
write a privacy policy guide to cookies ''Draft published by anti''

Styling

+- make boardlist and bottom thread interactions into bars. This will require major styling changes.

thread watcher: move to after Reply to improve CLS
styling of plain links in css
styling of submit buttons: d6a8dca27e
check all pages are compatible with all themes! [front page, rules page, options, any others broken?]
categorize js options into tabs, clean up framesets, give them header comments
—–
Stretch goals (can probably be ignored until launch)
is image resizing done before we check if it's valid? is wasteful
lots of potential conditions where an error is thrown and no undoImage in post.php (e.g. max_size)
rand and catalog logs out mods
may have lost compatibility with app (esp catalog/overboard, omitted some of those commits from Jan 2021)
inlining doesn't work for mods
create a way to view denied appeal posts?
deleting multiple posts at once using js/quick-post-controls just deletes images (accepted issue)
PDF thumbnails, explain imagemagick workaround: https://stackoverflow.com/questions/52998331/imagemagick-security-policy-pdf-blocking-conversion
config for SEO options
clean up tabs/spaces combos (wontfix here. Makes downstreaming patches a pain)
grep -r -P " [\t]|[\t] " | grep -v Binary | cut -d: -f 1 | sort | uniq
grep -r -P " [\t]|[\t] " | grep -v Binary | cut -d: -f 1 | sort | uniq

Long-term todo: (some of these will not be used on leftypol, just mentioning for more completeness)

npfchan: Bugfix: max_body counted lines as two chars instead of one as js did. Unified lineshift chars to just "\n". ## Is this destructive?
lainchan: WYSIWSG editors
npfchan: shadow delete
npfchan: user ID cookies, and features that rely on them (cookie bans)
in theory, grep their codebase for 'cookie', https://stackoverflow.com/questions/1337320/how-to-grep-git-commit-diffs-or-contents-for-a-certain-word
npfchan: IP hashing
-(?) move the images and fonts into stylesheets folder, rename if needed
-(?) remove dark lain fonts?

Other

declined features:

various styling
lainchan: error handler overhaul
lainchan: Slack notification support
lainchan: simplified mod dashboard layout
lainchan: ukko2, ukko3, ukko4
lainchan: posting threads from ukko (unsolved antispam)
lainchan: extra themes for calendar, zine, radio, stream, etc
lainchan: board aliases (many commits)
lainchan: Rebuild themes after stickying or locking post, so that catalog gets rebuilt
npfchan: Bantz and nicenotice messages mod tools
npfchan: forced flags
npfchan and lainchan: twemoji support
npfchan: period-based filters (max posts per interval, e.g. 5 threads per hour)
npfchan: multiple dice roll ( 8b4cd6b801 ), inline dice roll
npfchan: Ban & Delete all post by IP in one go
npfchan: multiple file url function
npfchan: users can delete seperate files
npfchan: Deny GETs for users that don't have posting history
npfchan: Updated and fixed RSS file creator template

Disco added features: (modifications on other imported features)

lainchan: shuffle thread order instead of sorting for Rand overboard
lainchan: fixes for overboard RSS feeds
npfchan: Makes the new thread stuff be collapsed by default and you have to click on [New Thread] for it to expand - use leftypol_lainchan method on catalog form, no delay before retracting

Migration notes

try to fix the tinyboard flag tags by transfering them from body to body_nomarkup: example post http://76i2c3hn55fcj5nut3tqlboqqbbh23zvphv7lefk3vftpx6wketlanyd.onion/edu/res/5858.html#5859
DO NOT TEST THIS ON A LIVE OR WELL-DEVELOPED DATABASE!
Some fields have different lengths, make sure to check and adjust them

Progress through other codebases

[vichan]
Currently up to date : 12 Jan 2023

[leftypol]
Not up to date….

—NICOCHAN — [non-public: need admin git account]: https://git.leftypol.org/perdedora/nicochan/commits/branch/composer?page=22 [26 now?]

of note:

reduce unnecessary rebuilds on D+

fc6f861a4b

Notes shamelessly stolen from Disco No idea of what has already been upstreamed to Vichan in the meantime. **** Welcome to sticky. Edit it as things change. > **Current tasks:** ||| **Disco:** >check for updates on https://github.com/vichan-devel/vichan/pull/463 >verify the SQLs all match the appropriate implementation (e.g. nfp vs vichan warnings?) ||| '''Anti:''' > ||| '''Misato:''' > —————————————————————– —————————————————————– —————————————————————– ### Outstanding issues: [note: this doesn't include missing requested features in current leftypol] #### Functional - CUSTOM SPAM FILTERS IGNORED UNTIL END, including the adding of fresh ones - CAPTCHA ignored until end, my lainchan changes are contradictory - see various commits, including: https://github.com/vichan-devel/vichan/commit/7571df84c852a767b04513452bb7b2458fe7d63e'' - https://infosec.mozilla.org/guidelines/web_security#x-xss-protection (esp mod cookies to mod.php) - captcha on post report appears to be broken [if solved, move its $config setting to CAPTCHAs] - go through the themes and either header template for mobile compatability e.g.: https://github.com/towards-a-new-leftypol/leftypol_lainchan/commit/3eea75ef77a2b6f4b66bd0216259d66f4fe72f83 - attach thread stats to Unique IPs directly, not implicitly (wontfix?) - document that captcha requires php curl , ban require php bc or math ^^^ I think ext-bcmath is a hard requirement of the lifo/ip composer package now -test all features, esp. warning ? log.php : $config['mod']['mod_board_log'] is undefined can't reproduce? - show all announcements page (announcements.html) not loading can't reproduce - double escaping for subject line in OP page title [check meta tags too] - fix the thread auto-update and bottom menu to a bottom bar - PM inbox shows `( unread)` when there are none unread - make statistics archive itself daily, as it is currently very short-term - omitted vichan's move from instance-config.php->secrets.php, seems incomplete - write a privacy policy guide to cookies ''Draft published by anti'' #### Styling +- make boardlist and bottom thread interactions into bars. This will require major styling changes. - thread watcher: move to after Reply to improve CLS - styling of plain <a> links in css - styling of submit buttons: https://git.leftypol.org/leftypol/leftypol/commit/d6a8dca27e00804aaad637f9c7ffd2a60e447fef - check all pages are compatible with all themes! [front page, rules page, options, any others broken?] - categorize js options into tabs, clean up framesets, give them header comments —– Stretch goals (can probably be ignored until launch) - is image resizing done before we check if it's valid? is wasteful - lots of potential conditions where an error is thrown and no undoImage in post.php (e.g. max_size) - rand and catalog logs out mods - may have lost compatibility with app (esp catalog/overboard, omitted some of those commits from Jan 2021) - inlining doesn't work for mods - create a way to view denied appeal posts? - deleting multiple posts at once using js/quick-post-controls just deletes images (accepted issue) - PDF thumbnails, explain imagemagick workaround: https://stackoverflow.com/questions/52998331/imagemagick-security-policy-pdf-blocking-conversion - config for SEO options - clean up tabs/spaces combos (wontfix here. Makes downstreaming patches a pain) grep -r -P " [\t]|[\t] " | grep -v Binary | cut -d: -f 1 | sort | uniq grep -r -P " [\t]|[\t] " | grep -v Binary | cut -d: -f 1 | sort | uniq Long-term todo: (some of these will not be used on leftypol, just mentioning for more completeness) - npfchan: Bugfix: max_body counted lines as two chars instead of one as js did. Unified lineshift chars to just "\n". ## Is this destructive? - lainchan: WYSIWSG editors - npfchan: shadow delete - npfchan: user ID cookies, and features that rely on them (cookie bans) in theory, grep their codebase for 'cookie', https://stackoverflow.com/questions/1337320/how-to-grep-git-commit-diffs-or-contents-for-a-certain-word - npfchan: IP hashing -(?) move the images and fonts into stylesheets folder, rename if needed -(?) remove dark lain fonts? #### Other declined features: - various styling - lainchan: error handler overhaul - lainchan: Slack notification support - lainchan: simplified mod dashboard layout - lainchan: ukko2, ukko3, ukko4 - lainchan: posting threads from ukko (unsolved antispam) - lainchan: extra themes for calendar, zine, radio, stream, etc - lainchan: board aliases (many commits) - lainchan: Rebuild themes after stickying or locking post, so that catalog gets rebuilt - npfchan: Bantz and nicenotice messages mod tools - npfchan: forced flags - npfchan and lainchan: twemoji support - npfchan: period-based filters (max posts per interval, e.g. 5 threads per hour) - npfchan: multiple dice roll ( https://github.com/fallenPineapple/NPFchan/commit/8b4cd6b801b6caebc79e74443503b26aff4cf53a ), inline dice roll - npfchan: Ban & Delete all post by IP in one go - npfchan: multiple file url function - npfchan: users can delete seperate files - npfchan: Deny GETs for users that don't have posting history - npfchan: Updated and fixed RSS file creator template Disco added features: (modifications on other imported features) - lainchan: shuffle thread order instead of sorting for Rand overboard - lainchan: fixes for overboard RSS feeds - npfchan: Makes the new thread stuff be collapsed by default and you have to click on [New Thread] for it to expand - use leftypol_lainchan method on catalog form, no delay before retracting ### Migration notes - try to fix the tinyboard flag tags by transfering them from body to body_nomarkup: example post http://76i2c3hn55fcj5nut3tqlboqqbbh23zvphv7lefk3vftpx6wketlanyd.onion/edu/res/5858.html#5859 - DO NOT TEST THIS ON A LIVE OR WELL-DEVELOPED DATABASE! - Some fields have different lengths, make sure to check and adjust them ## Progress through other codebases [vichan] Currently up to date : 12 Jan 2023 [leftypol] Not up to date…. —NICOCHAN — [non-public: need admin git account] : https://git.leftypol.org/perdedora/nicochan/commits/branch/composer?page=22 [26 now?] of note: # reduce unnecessary rebuilds on D+ https://git.leftypol.org/perdedora/nicochan/commit/fc6f861a4b03885fae89dbadfce7b9893c75282f

https://infosec.mozilla.org/guidelines/web_security#csrf-prevention